Manager subview components #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
force-pushed
the
manager-subview-components
branch
2 times, most recently
from
d7f447e
to
954062f
Compare
|
Ready for review now. The broken link will be fixed in the next PR, which should be merged at the same time. |
anttimaki
force-pushed
the
downloadmodmodal-refactor
branch
from
e7f95e1
to
b6a8d07
Compare
anttimaki
force-pushed
the
manager-subview-components
branch
from
954062f
to
0e014ea
Compare
anttimaki
force-pushed
the
manager-subview-components
branch
from
0e014ea
to
6202516
Compare
MythicManiac
approved these changes
Dec 1, 2022
anttimaki
force-pushed
the
manager-subview-components
branch
from
6202516
to
a9d3db9
Compare
|
Fixed this line to use |
ebkr
approved these changes
Dec 6, 2022
The idea is that the selected subview will later be selected automatically by the routing component, but for this to work the view pretty much needs to be a single component. The commit actually contains a broken link for moving between the subviews. I didn't want to waste energy solving that since it would be overwritten by a future commit anyway. Since the component will be defined in the routing config in the future it made sense to me that the component is imported directly rather than via a provider. To my understanding the point of the providers is to allow swapping components for customization, and in the future that will be handled by the router config. Refs TS-1310
Instead of passing the filtering function as a prop to the modal that handles updating filter values, watch changes to those values instead. This makes it easier to move the filtering function to another module in the future. As a side effect of this change, the mod list is now updated immediately when a filter is changed. Keen eyes can detect the mod list updating under the modal. I didn't detect any performance issues with this approach, but if problems arises with this approach, we can change the modal to store the changes to filters locally and commit them to Vuex store only when the modal is closed. Instead of calling the method responsible for sorting the mod list (which calls the filtering method behind the scenes), call the filtering method directly. Changes done in the filter modal don't affect the sorting, so sorting the list seems unnecessary. Refs TS-1311
The idea is that the selected subview will later be selected automatically by the routing component, but for this to work the view pretty much needs to be a single component. Since the component will be defined in the routing config in the future it made sense to me that the component is imported directly rather than via a provider. To my understanding the point of the providers is to allow swapping components for customization, and in the future that will be handled by the router config. Refs TS-1311
anttimaki
force-pushed
the
manager-subview-components
branch
from
a9d3db9
to
b857235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR since it contains a broken link and I haven't tested this properly yet. Wanted to put this out here in case there's some reviews going on during the weekend, as feedback is very welcome.